Fix setup instructions #2698
Merged
Fix setup instructions #2698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishabosha
reviewed
Feb 15, 2023
_overviews/getting-started/index.md
Outdated
| @@ -52,15 +52,22 @@ Install it on your system with the following instructions. | |||
| Run the following command in your terminal, following the on-screen instructions: | |||
| {% include code-snippet.html language='bash' codeSnippet=site.data.setup-scala.macOS-brew %} | |||
| {% altDetails cs-setup-macos-nobrew "Alternatively, if you don't use Homebrew:" %} | |||
There was a problem hiding this comment.
Suggested change
| {% altDetails cs-setup-macos-nobrew "Alternatively, if you don't use Homebrew:" %} | |
| {% altDetails cs-setup-macos-nobrew "Alternatively for Apple Silicon, or if you don't use Homebrew:" %} |
bishabosha
approved these changes
Feb 15, 2023
bishabosha
approved these changes
Feb 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think these setup instructions are too complicated but we need to fix them so that they work with the current state of things.
Ideally, we should have a single script that would download the correct binary based on the user OS and architecture.