Skip to content

Add Automatic-Module-Name to MANIFEST.INF to all modules #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
schrepfler opened this issue Nov 13, 2019 · 3 comments · Fixed by #128
Closed

Add Automatic-Module-Name to MANIFEST.INF to all modules #71

schrepfler opened this issue Nov 13, 2019 · 3 comments · Fixed by #128

Comments

@schrepfler
Copy link

In order to increase compatibility on JDK versions with modules consider adding Automatic-Module-Name in the MANIFEST.INF along the lines of akka/akka#23960 or perhaps even implement properly the module-info descriptor.
I've raised scala/scala-xml#367 scala/scala-collection-compat#263 scala/scala-java8-compat#168 scala/scala-collection-contrib#65 scala/scala-parallel-collections#82 and scala/scala-parser-combinators#248 as I wasn't aware of this project.

@lrytz
Copy link
Member

lrytz commented Nov 18, 2019

Here's how this was added to scala/scala: scala/scala#6395. I think the same should apply to modules.

@schrepfler
Copy link
Author

Just a note, this will not be enough to address building with jlink (it seems) as it seems automodules aren’t supported/strict enough.

SethTisue added a commit to SethTisue/sbt-scala-module that referenced this issue May 5, 2021
@SethTisue
Copy link
Member

PR: #128, inspired by @makingthematrix's additional pressure at https://users.scala-lang.org/t/scala-jdk-11-and-jpms/6102/37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants