Skip to content

Add Automatic-Module-Name to MANIFEST.INF #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
schrepfler opened this issue Nov 13, 2019 · 5 comments
Closed

Add Automatic-Module-Name to MANIFEST.INF #367

schrepfler opened this issue Nov 13, 2019 · 5 comments

Comments

@schrepfler
Copy link

In order to increase compatibility on JDK versions with modules consider adding Automatic-Module-Name in the MANIFEST.INF along the lines of akka/akka#23960 or perhaps even implement properly the module-info descriptor.

@ashawley
Copy link
Member

I predict this may be something that could be handled upstream in the shared sbt plugin https://github.com/scala/sbt-scala-module/

@schrepfler
Copy link
Author

Ah, wasn't aware there's a shared build plugin. I'll raise it upstream, thanks.

@ashawley
Copy link
Member

We'll see. We can keep this open, though.

@ashawley
Copy link
Member

I don't know enough, but maybe it's even something that would be done in sbt or even Scala itself.

@SethTisue
Copy link
Member

fixed by #518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants