Skip to content

Fatal warnings #608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 22, 2016
Merged

Fatal warnings #608

merged 5 commits into from
Oct 22, 2016

Conversation

jarrodu
Copy link
Member

@jarrodu jarrodu commented Oct 21, 2016

Here is the rest of the improvements for the tut and the fixes to the tour to make tut pass.

@jarrodu
Copy link
Member Author

jarrodu commented Oct 21, 2016

fixes #606

@heathermiller
Copy link
Member

LGTM, thanks @jarrodwb!

@heathermiller heathermiller merged commit 631a6fd into scala:master Oct 22, 2016
@SethTisue
Copy link
Member

sweet!

@mpociecha
Copy link
Contributor

Wouldn't it be better to just squash such commits before merging PRs? It doesn't make sense to merge merge commits etc.

@jarrodu
Copy link
Member Author

jarrodu commented Oct 22, 2016

Yup. I agree. I was tired and wanted to get the PR summited before I went to bed.

Not my best work for sure. The commits are a bit embarrassing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants