Skip to content

enable -Xfatal-warnings in tut? #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SethTisue opened this issue Oct 20, 2016 · 3 comments
Closed

enable -Xfatal-warnings in tut? #606

SethTisue opened this issue Oct 20, 2016 · 3 comments

Comments

@SethTisue
Copy link
Member

this would catch things like inadvertent/leftover use of postfix syntax (e.g. #605). it would catch all sorts of things we want caught, really

I hope there wouldn't be a lot of false negatives — my guess is that it would be fine. lots of real projects are able to adhere to -Xfatal-warnings

@jarrodu
Copy link
Member

jarrodu commented Oct 20, 2016

https://travis-ci.org/jarrodwb/scala.github.com/builds/169330245

I got tut to fail on a branch I am working on. It makes sense to me to fix the problems before I make a pull request. I think we need to merge in #605 first and also take a look at and fix tutorials/tour/implicit-conversions.md. It also throws an error.

@jarrodu
Copy link
Member

jarrodu commented Oct 20, 2016

I am off to bed but thanks for the fast track on #605. See you tomorrow.

@jarrodu jarrodu mentioned this issue Oct 21, 2016
@SethTisue
Copy link
Member Author

fixed in #608

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants