Skip to content

Remove toc in macros guide, fix numbering #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 14, 2014
Merged

Conversation

heathermiller
Copy link
Member

review by @xeno-by

@xeno-by
Copy link
Contributor

xeno-by commented Feb 14, 2014

As I mentioned before, sometimes the right-hand side toc gets messed up (e.g. missing some entries). What do we do if that starts happening again?

@heathermiller
Copy link
Member Author

It doesn't seem to be happening now. If it happens again, we have to figure out which characters are in the header that're screwing up the JavaScript, and we have to update the regex to handle that offensive character. Having outdated manually updated TOCs is worse IMO.

@xeno-by
Copy link
Contributor

xeno-by commented Feb 14, 2014

I see, thank you!

xeno-by added a commit that referenced this pull request Feb 14, 2014
Remove toc in macros guide, fix numbering
@xeno-by xeno-by merged commit 3efef1e into master Feb 14, 2014
@heathermiller heathermiller deleted the macros-remove-toc branch February 14, 2014 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants