Skip to content

NodeJSEnv run does not fail if an ESModule fails #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gzm0 opened this issue Jan 16, 2022 · 0 comments · Fixed by #18
Closed

NodeJSEnv run does not fail if an ESModule fails #17

gzm0 opened this issue Jan 16, 2022 · 0 comments · Fixed by #18
Assignees
@gzm0
Labels
bug Something isn't working

Comments

@gzm0
Copy link
Contributor

gzm0 commented Jan 16, 2022

How to reproduce in this repo: Change Script to ESModule in:

scala-js-js-envs/js-envs-test-kit/src/main/scala/org/scalajs/jsenv/test/kit/TestKit.scala

Line 161 in 01b0e95

List(Input.Script(p))

The test suite will now hang for NodeJSEnv.
@gzm0 gzm0 added the bug Something isn't working label Jan 16, 2022
@gzm0 gzm0 mentioned this issue Jan 16, 2022
Merged
@gzm0 gzm0 self-assigned this Jan 17, 2022
gzm0 added a commit to gzm0/scala-js-js-envs that referenced this issue Jan 17, 2022
@gzm0
Fix scala-js#17: Fail run in NodeJSEnv if ESModule fails
6e844f2
gzm0 added a commit to gzm0/scala-js-js-envs that referenced this issue Jan 17, 2022
@gzm0
Fix scala-js#17: Fail run in NodeJSEnv if ESModule fails
4a0110d
@gzm0 gzm0 linked a pull request Jan 17, 2022 that will close this issue
Fix #17: Fail run in NodeJSEnv if ESModule fails #18
Merged
gzm0 added a commit to gzm0/scala-js-js-envs that referenced this issue Jan 18, 2022
@gzm0
Fix scala-js#17: Fail run in NodeJSEnv if ESModule fails
82089d8
gzm0 added a commit to gzm0/scala-js-js-envs that referenced this issue Jan 18, 2022
@gzm0
Fix scala-js#17: Fail run in NodeJSEnv if ESModule fails
855a7eb
gzm0 added a commit to gzm0/scala-js-js-envs that referenced this issue Jan 22, 2022
@gzm0
Fix scala-js#17: Fail run in NodeJSEnv if ESModule fails
5ea4d40
@sjrd sjrd closed this as completed in #18 Jan 22, 2022
sjrd added a commit that referenced this issue Jan 22, 2022
@sjrd
Merge pull request #18 from gzm0/fix-es-module-errors
eab6373 
Fix #17: Fail run in NodeJSEnv if ESModule fails
gzm0 added a commit to gzm0/scala-js that referenced this issue Jan 31, 2022
@gzm0
Upgrade JS envs to 1.3.0
cb4f5c7 
We need the fix to scala-js/scala-js-js-envs#17 and some API
improvements in the test kit.
gzm0 added a commit to gzm0/scala-js that referenced this issue Feb 4, 2022
@gzm0
Upgrade JS envs to 1.3.0
f7bfb17 
We need the fix to scala-js/scala-js-js-envs#17 and some API
improvements in the test kit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzm0 gzm0

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #17: Fail run in NodeJSEnv if ESModule fails gzm0/scala-js-js-envs
1 participant
@gzm0