Skip to content

Add tests for {node + jsdom, chrome, firefox, webworkers} #540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 1, 2021
Merged

Add tests for {node + jsdom, chrome, firefox, webworkers} #540

merged 2 commits into from
Sep 1, 2021

Conversation

japgolly
Copy link
Contributor

Closes #520

@japgolly japgolly requested a review from armanbilge August 31, 2021 23:04
armanbilge
armanbilge approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@armanbilge armanbilge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting lift off on this, this is a really really important one.

@armanbilge armanbilge merged commit f005384 into master Sep 1, 2021
@armanbilge armanbilge deleted the topic/tests branch September 1, 2021 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@armanbilge armanbilge armanbilge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for various environments
2 participants
@japgolly @armanbilge