Skip to content

Add tests for various environments #520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
japgolly opened this issue Aug 30, 2021 · 1 comment · Fixed by #540
Closed

Add tests for various environments #520

japgolly opened this issue Aug 30, 2021 · 1 comment · Fixed by #540
Assignees
@japgolly
Milestone
v2.0.0

Comments

@japgolly
Copy link
Contributor

Why?

There are some things that are not immediately obvious to me that they'll work as I'm expected in various environments. I want automated tests for something, and I also want to ability to request new tests from contributors.

Envs:

  • browsers
  • web workers
  • node + jsdom
  • node (without jsdom)
@japgolly japgolly self-assigned this Aug 30, 2021
@japgolly japgolly added this to the v2.0.0 milestone Aug 30, 2021
@japgolly
Copy link
Contributor Author

Note: I'm gonna wait until all PRs are merged and #527 is complete.

japgolly added a commit that referenced this issue Aug 31, 2021
@japgolly
Add tests for {node + jsdom, chrome, firefox, webworkers}
453c4cb 
Closes #520
@japgolly japgolly mentioned this issue Aug 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@japgolly japgolly

Labels
None yet
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging a pull request may close this issue.

Add tests for {node + jsdom, chrome, firefox, webworkers} scala-js/scala-js-dom
1 participant
@japgolly