Fix #504 #506
Merged
Fix #504 #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
armanbilge
approved these changes
Aug 26, 2021
|
Also, this doesn't completely fix #504 right? We still need to do something about the version (hard-code it I guess)? |
|
Yeah it doesn't fix the version problem but it's only a problem on the 1.x branch and I think it will be less effort to just set the version manually on a release. I'm hoping we don't do another 1.x release anyway :) |
|
Ok I hope so! |
japgolly
commented
Aug 26, 2021
| @@ -17,6 +22,7 @@ lazy val root = project | |||
|
|
|||
| name := "Scala.js DOM" | |||
|
|
|||
| ThisBuild / version := "1.2.0" | |||
There was a problem hiding this comment.
@armanbilge erm......
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our release GitHub Actions job performs the release for SJS 0.6 and 1.0 in parallel. This prevents each parallel processes from removing each other's deployment.