Skip to content

(Non-snapshot) release is broken #504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
armanbilge opened this issue Aug 25, 2021 · 2 comments · Fixed by #506
Closed

(Non-snapshot) release is broken #504

armanbilge opened this issue Aug 25, 2021 · 2 comments · Fixed by #506
Assignees
@japgolly
Labels
bug infrastructure

Comments

@armanbilge
Copy link
Member

We got bit by the prepareForScala210.sh hack again :(

When this script runs in CI, it modifies the build.sbt file. This causes the git repo to become dirty, so when the release script runs it derives a version number like 1.2.0+0-2471029d+20210825-0618-SNAPSHOT. This makes it impossible to publish a non-shapshot release.

Possible fixes:

  • hard-code version v1.2.0 into the build.sbt. No idea if this would work, the docs for sbt-ci-release specifically say you must not define version.
  • Don't publish for Scala 2.10 so we don't have to run this script in CI. If anyone complains, deal with it then.
@japgolly
Copy link
Contributor

@armanbilge ok cool, I just manually set the version in sbt (which sbt-dynver recognises as an override) and it seems to have worked. Don't close this yet though, we're actually lucky the release worked but I need to leave ASAP -- will continue later this arvo

japgolly added a commit that referenced this issue Aug 26, 2021
@japgolly
Fix #504
fbe2203 
Our release GitHub Actions job performs the release for SJS 0.6 and 1.0 in parallel. This prevents each parallel processes from removing each other's deployment.
@japgolly japgolly linked a pull request Aug 26, 2021 that will close this issue
Fix #504 #506
Merged
@armanbilge armanbilge mentioned this issue Aug 26, 2021
Merged
armanbilge added a commit that referenced this issue Aug 26, 2021
@armanbilge
Merge pull request #506 from scala-js/issue/504
03cb1d6 
Fix #504
@armanbilge armanbilge reopened this Aug 26, 2021
@japgolly
Copy link
Contributor

I think we're good now:

  • snapshot releases work (on both master + series/v1.x)
  • tagged releases work will on master
  • tagged releases work on v1.x with a manual version-setting step

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@japgolly japgolly

Labels
bug infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #504 scala-js/scala-js-dom
2 participants
@japgolly @armanbilge