Skip to content

Lots of changes #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 18, 2014
Merged

Lots of changes #10

merged 4 commits into from
Feb 18, 2014

Conversation

lihaoyi
Copy link
Contributor

@lihaoyi lihaoyi commented Feb 18, 2014

  • js.Function[T, js.Any] -> js.Function[T, _], so you don't need that stupid (): js.Any thing at the end of a lambda
  • Collapsed all the telescoped overloads (including constructors) to use the new default argument support instead
  • Deleted more ms-specific things
  • Added more docs where it was missing e.g. for setInterval

@sjrd could you take a look at this? I tried it out locally, and the generated javascript seems to do what I want, but I'd like to make sure I'm not doing subtly wrong with this js.Function[T, _] or default-argument thing which I've never used before

@sjrd
Copy link
Member

sjrd commented Feb 18, 2014

LGTM Yeah!

sjrd added a commit that referenced this pull request Feb 18, 2014
@sjrd sjrd merged commit 8ffe180 into scala-js:master Feb 18, 2014
Visbone pushed a commit to Visbone/scala-js-dom that referenced this pull request Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants