Skip to content

Commit 8ffe180

Browse files
committed
Merge pull request #10 from lihaoyi/master
Lots of changes
2 parents 756b6bc + 48108da commit 8ffe180

File tree

6 files changed

+419
-634
lines changed

6 files changed

+419
-634
lines changed

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Usage
1717

1818
Add the following to your sbt build definition:
1919

20-
libraryDependencies += "org.scala-lang.modules.scalajs" %% "scalajs-dom" % "0.1-SNAPSHOT"
20+
libraryDependencies += "org.scala-lang.modules.scalajs" %% "scalajs-dom" % "0.2"
2121

2222
then enjoy the types available in `org.scalajs.dom`.
2323

@@ -29,7 +29,7 @@ Contributing
2929
Scala-js-dom is a work in progress. The current code base is a hodgepodge of auto-generated/scraped/hand-tweaked code, and is full of rough edges. If you see something that you think can be improved, feel free to send a pull request. These could include:
3030

3131
- Improved doc-comments; who doesn't love better docs?
32-
- Missing methods/properties/classes; send the PR adding it in including it together with a link to an authoritative source (e.g. MDN) and it should get merge
32+
- Missing methods/properties/classes; send the PR adding it in including it together with a link to an authoritative source (e.g. MDN) and it should get merged.
3333
- Additional extensions (in `org.scalajs.dom.extensions`). These currently represent an arbitrary collection of helpers that have been needed so far. If there's some implicit that you find you need and you think other people will to, send a pull request and we can talk about it.
3434

3535
License

src/main/scala/org/scalajs/dom/Css.scala

Lines changed: 9 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -186,9 +186,7 @@ class CSSStyleDeclaration extends js.Object {
186186
@scala.scalajs.js.annotation.JSBracketAccess
187187
def update(index: js.Number, v: js.String): Unit = ???
188188

189-
def setProperty(propertyName: js.String, value: js.String, priority: js.String): Unit = ???
190-
191-
def setProperty(propertyName: js.String, value: js.String): Unit = ???
189+
def setProperty(propertyName: js.String, value: js.String, priority: js.String = ???): Unit = ???
192190

193191
var animationFillMode: js.String = _
194192
var floodColor: js.String = _
@@ -335,40 +333,28 @@ class CSSStyleSheet extends StyleSheet {
335333
var cssRules: CSSRuleList = _
336334
var id: js.String = _
337335

338-
def addImport(bstrURL: js.String, lIndex: js.Number): js.Number = ???
339-
340-
def addImport(bstrURL: js.String): js.Number = ???
341-
342-
def addPageRule(bstrSelector: js.String, bstrStyle: js.String, lIndex: js.Number): js.Number = ???
343-
344-
def addPageRule(bstrSelector: js.String, bstrStyle: js.String): js.Number = ???
345-
346-
def insertRule(rule: js.String, index: js.Number): js.Number = ???
336+
def addImport(bstrURL: js.String, lIndex: js.Number = ???): js.Number = ???
347337

338+
def addPageRule(bstrSelector: js.String, bstrStyle: js.String, lIndex: js.Number = ???): js.Number = ???
348339
/**
349340
* The CSSStyleSheet.insertRule() method inserts a new style rule into the current
350341
* style sheet.
351342
*
352343
* MDN
353344
*/
354-
def insertRule(rule: js.String): js.Number = ???
345+
def insertRule(rule: js.String, index: js.Number = ???): js.Number = ???
355346

356-
def removeRule(lIndex: js.Number): Unit = ???
357-
358-
def deleteRule(index: js.Number): Unit = ???
359347

348+
def removeRule(lIndex: js.Number): Unit = ???
360349
/**
361350
* Deletes a rule from the style sheet.
362351
*
363352
* MDN
364353
*/
365-
def deleteRule(): Unit = ???
354+
def deleteRule(index: js.Number = ???): Unit = ???
366355

367-
def addRule(bstrSelector: js.String, bstrStyle: js.String, lIndex: js.Number): js.Number = ???
368356

369-
def addRule(bstrSelector: js.String, bstrStyle: js.String): js.Number = ???
370-
371-
def addRule(bstrSelector: js.String): js.Number = ???
357+
def addRule(bstrSelector: js.String, bstrStyle: js.String = ???, lIndex: js.Number = ???): js.Number = ???
372358

373359
def removeImport(lIndex: js.Number): Unit = ???
374360
}
@@ -406,13 +392,10 @@ class CSSMediaRule extends CSSRule {
406392
var media: MediaList = _
407393
var cssRules: CSSRuleList = _
408394

409-
def insertRule(rule: js.String, index: js.Number): js.Number = ???
410-
411-
def insertRule(rule: js.String): js.Number = ???
395+
def insertRule(rule: js.String, index: js.Number = ???): js.Number = ???
412396

413-
def deleteRule(index: js.Number): Unit = ???
414397

415-
def deleteRule(): Unit = ???
398+
def deleteRule(index: js.Number = ???): Unit = ???
416399
}
417400

418401
/**

0 commit comments

Comments
 (0)