Remove the const_generics feature flag
#25
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the "unstable" feature no longer compiles on recent nightly Rust toolchains, because it enables the `const_generics` feature flag. Since const generics have stabilized, this feature flag is no longer necessary, and results in a compilation error on recent toolchains. This commit removes `#[feature(const_generics)]` from the crate. Now, the "unstable" feature builds on recent nightly compilers. Additionally, we can remove the "unstable" feature flag from the impls for converting volatile arrays to slices, as that impl no longer requires an unstable feature. In order to make the tests pass on stable Rust after removing the unstable feature flag from the impls for arrays, I had to modify the examples so that they no longer use other unstable methods, such as `copy_from_slice`. I think the new examples still get the point across, although they're maybe not quite as nice... Fixes rust-osdev#24
phil-opp
approved these changes
Apr 24, 2022
phil-opp
added a commit
that referenced
this pull request
Apr 24, 2022
|
Published as version 0.4.5 |
No worries, thanks for the new release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the "unstable" feature no longer compiles on recent nightly
Rust toolchains, because it enables the
const_genericsfeature flag.Since const generics have stabilized, this feature flag is no longer
necessary, and results in a compilation error on recent toolchains.
This commit removes
#[feature(const_generics)]from the crate. Now,the "unstable" feature builds on recent nightly compilers. Additionally,
we can remove the "unstable" feature flag from the impls for converting
volatile arrays to slices, as that impl no longer requires an unstable
feature.
In order to make the tests pass on stable Rust after removing the
unstable feature flag from the impls for arrays, I had to modify the
examples so that they no longer use other unstable methods, such as
copy_from_slice. I think the new examples still get the point across,although they're maybe not quite as nice...
Fixes #24