Removal of the const_generics feature #24
Comments
hawkw
added a commit
to hawkw/volatile
that referenced
this issue
Mar 31, 2022
Currently, the "unstable" feature no longer compiles on recent nightly Rust toolchains, because it enables the `const_generics` feature flag. Since const generics have stabilized, this feature flag is no longer necessary, and results in a compilation error on recent toolchains. This commit removes `#[feature(const_generics)]` from the crate. Now, the "unstable" feature builds on recent nightly compilers. Additionally, we can remove the "unstable" feature flag from the impls for converting volatile arrays to slices, as that impl no longer requires an unstable feature. In order to make the tests pass on stable Rust after removing the unstable feature flag from the impls for arrays, I had to modify the examples so that they no longer use other unstable methods, such as `copy_from_slice`. I think the new examples still get the point across, although they're maybe not quite as nice... Fixes rust-osdev#24
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The const_generics feature has recently been removed in favor of adt_const_params, which breaks unstable builds the most recent nightly. I believe the fix is as simple as replacing
#![cfg_attr(feature = "unstable", feature(const_generics))]with#![cfg_attr(feature = "unstable", feature(adt_const_params))]The text was updated successfully, but these errors were encountered: