Implement volatile loads and stores #167
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoyo
reviewed
Apr 26, 2022
| let loaded_value = function.new_local(None, value_type, &format!("loadedValue{}", unsafe { RETURN_VALUE_COUNT })); | ||
| block.add_assignment(None, loaded_value, deref); | ||
| loaded_value.to_rvalue() | ||
| // TODO: handle non-natural alignments |
There was a problem hiding this comment.
The rust repo requires that TODO should be annotated with a name. If you don't plan to fix this later, just put my username there.
| modified_destination_type = modified_destination_type.make_volatile(); | ||
| } | ||
|
|
||
| // FIXME: The type checking in `add_assignment` removes only one |
| let modified_ptr = self.cx.context.new_bitcast(None, ptr, modified_destination_type.make_pointer()); | ||
| let modified_destination = modified_ptr.dereference(None); | ||
| self.llbb().add_assignment(None, modified_destination, val); | ||
| // TODO: handle `MemFlags::NONTEMPORAL`. |
| let value_type = deref.get_type(); | ||
|
|
||
| // If `is_volatile == true`, convert `ptr` to `volatile value_type *` | ||
| // and try dereference again. (libgccjit doesn't provide a way to get |
There was a problem hiding this comment.
I'm not sure if that's what you're talking about, but an alternative is to do:
ptr.get_type().get_pointee()There was a problem hiding this comment.
Thanks, that's exactly what I was looking for.
|
The CI failed for libgccjit12, btw. Not sure if it's normal. |
|
Not normal, I think. Also, I found that volatile reads are still being eliminated by p_count.write_volatile(0);
STORAGE.add(0).read_volatile();
STORAGE.add(PAGE_SIZE).read_volatile();
STORAGE.add(0).write_volatile(1);
|
|
I just got bit by this bug. Is there any plan to fix it ? |
|
@kellda: I will try to take a look in the upcomming weeks. |
|
@kellda: This was implemented in #572 and rust-lang/gcc@50d1270. Please tell me if that works for you. |
|
Yes it works, thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #166.