Skip to content

Debuginfo locals #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Dec 16, 2019
Merged

Debuginfo locals #802

merged 21 commits into from
Dec 16, 2019

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Nov 19, 2019

TODO

  • Undo testing changes
  • Correct debuginfo for non-mutable references and pointers
  • Use DW_TAG_param
  • Handle DW_AT_location for CPlaceInner::Addr

cc https://github.com/bjorn3/rustc_codegen_cranelift/issues/166

@bjorn3 bjorn3 added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-debuginfo Area: Debugging information at runtime in generated code. labels Nov 19, 2019
@bjorn3 bjorn3 force-pushed the debuginfo_locals branch 3 times, most recently from df64ba0 to 332870b Compare December 1, 2019 12:01
LLDB doesn't understand base address entries
* Only format global _comments when debug_assertions are enabled
* Only call build_value_labels_ranges in base.rs when debug_assertions are enabled

Benchmark #1: CHANNEL='pre' ../cargo.sh build
  Time (mean ± σ):     17.657 s ±  1.050 s    [User: 31.871 s, System: 3.014 s]
  Range (min … max):   16.907 s … 20.394 s    10 runs

Benchmark #2: ../cargo.sh build
  Time (mean ± σ):     16.640 s ±  0.255 s    [User: 30.238 s, System: 2.965 s]
  Range (min … max):   16.413 s … 17.186 s    10 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet PC without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

Summary
  '../cargo.sh build' ran
    1.06 ± 0.07 times faster than 'CHANNEL='pre' ../cargo.sh build'
@bjorn3 bjorn3 marked this pull request as ready for review December 16, 2019 11:14
@bjorn3
Copy link
Member Author

bjorn3 commented Dec 16, 2019

I am going to merge this with local debuginfo generation disabled to prevent bitrotting.

@bjorn3 bjorn3 merged commit 996bfd0 into master Dec 16, 2019
@bjorn3 bjorn3 deleted the debuginfo_locals branch December 16, 2019 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-debuginfo Area: Debugging information at runtime in generated code. C-enhancement Category: An issue proposing an enhancement or a PR with one.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant