Skip to content

Support rust-call abi for closures #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bjorn3 opened this issue Jul 21, 2018 · 0 comments
Closed

Support rust-call abi for closures #2

bjorn3 opened this issue Jul 21, 2018 · 0 comments
Assignees
@bjorn3
Milestone
MVP

Comments

@bjorn3
Copy link
Member

bjorn3 commented Jul 21, 2018

No description provided.

@bjorn3 bjorn3 added this to the MVP milestone Jul 21, 2018
@bjorn3 bjorn3 self-assigned this Jul 21, 2018
@bjorn3 bjorn3 closed this as completed in 874208b Jul 26, 2018
bjorn3 added a commit that referenced this issue Nov 23, 2019
@bjorn3
Benchmark simple-raytracer compilation
fc826a7 
[BENCH COMPILE] ebobby/simple-raytracer
Benchmark #1: RUSTFLAGS='' cargo build --target x86_64-apple-darwin
  Time (mean ± σ):     16.539 s ±  0.781 s    [User: 46.043 s, System: 3.822 s]
  Range (min … max):   15.057 s … 17.566 s    10 runs

Benchmark #2: ../cargo.sh build
  Time (mean ± σ):     14.550 s ±  0.443 s    [User: 25.856 s, System: 4.214 s]
  Range (min … max):   14.208 s … 15.751 s    10 runs

Summary
  '../cargo.sh build' ran
    1.14 ± 0.06 times faster than 'RUSTFLAGS='' cargo build --target x86_64-apple-darwin'
[BENCH RUN] ebobby/simple-raytracer
Benchmark #1: ./raytracer_cg_llvm
  Time (mean ± σ):      6.436 s ±  0.022 s    [User: 6.392 s, System: 0.018 s]
  Range (min … max):    6.408 s …  6.466 s    10 runs

Benchmark #2: ./raytracer_cg_clif
  Time (mean ± σ):      9.604 s ±  0.088 s    [User: 9.547 s, System: 0.023 s]
  Range (min … max):    9.503 s …  9.742 s    10 runs

Summary
  './raytracer_cg_llvm' ran
    1.49 ± 0.01 times faster than './raytracer_cg_clif'
bjorn3 added a commit that referenced this issue Nov 28, 2019
@bjorn3
Some optimizations
7ae0b40 
* Only format global _comments when debug_assertions are enabled
* Only call build_value_labels_ranges in base.rs when debug_assertions are enabled

Benchmark #1: CHANNEL='pre' ../cargo.sh build
  Time (mean ± σ):     17.657 s ±  1.050 s    [User: 31.871 s, System: 3.014 s]
  Range (min … max):   16.907 s … 20.394 s    10 runs

Benchmark #2: ../cargo.sh build
  Time (mean ± σ):     16.640 s ±  0.255 s    [User: 30.238 s, System: 2.965 s]
  Range (min … max):   16.413 s … 17.186 s    10 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet PC without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

Summary
  '../cargo.sh build' ran
    1.06 ± 0.07 times faster than 'CHANNEL='pre' ../cargo.sh build'
bjorn3 added a commit that referenced this issue Dec 1, 2019
@bjorn3
Some optimizations
c3a28b2 
* Only format global _comments when debug_assertions are enabled
* Only call build_value_labels_ranges in base.rs when debug_assertions are enabled

Benchmark #1: CHANNEL='pre' ../cargo.sh build
  Time (mean ± σ):     17.657 s ±  1.050 s    [User: 31.871 s, System: 3.014 s]
  Range (min … max):   16.907 s … 20.394 s    10 runs

Benchmark #2: ../cargo.sh build
  Time (mean ± σ):     16.640 s ±  0.255 s    [User: 30.238 s, System: 2.965 s]
  Range (min … max):   16.413 s … 17.186 s    10 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet PC without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

Summary
  '../cargo.sh build' ran
    1.06 ± 0.07 times faster than 'CHANNEL='pre' ../cargo.sh build'
bjorn3 added a commit that referenced this issue Dec 16, 2019
@bjorn3
Some optimizations
b86eb2e 
* Only format global _comments when debug_assertions are enabled
* Only call build_value_labels_ranges in base.rs when debug_assertions are enabled

Benchmark #1: CHANNEL='pre' ../cargo.sh build
  Time (mean ± σ):     17.657 s ±  1.050 s    [User: 31.871 s, System: 3.014 s]
  Range (min … max):   16.907 s … 20.394 s    10 runs

Benchmark #2: ../cargo.sh build
  Time (mean ± σ):     16.640 s ±  0.255 s    [User: 30.238 s, System: 2.965 s]
  Range (min … max):   16.413 s … 17.186 s    10 runs

  Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet PC without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.

Summary
  '../cargo.sh build' ran
    1.06 ± 0.07 times faster than 'CHANNEL='pre' ../cargo.sh build'
bjorn3 added a commit that referenced this issue Dec 20, 2019
@bjorn3
[OPT] Don't force return value of call to stack
a125b62 
Benchmark #1: ./simple_raytracer_before
  Time (mean ± σ):     14.420 s ±  0.568 s    [User: 14.376 s, System: 0.026 s]
  Range (min … max):   13.730 s … 15.170 s    10 runs

Benchmark #2: simple_raytracer_after
  Time (mean ± σ):     13.679 s ±  0.576 s    [User: 13.628 s, System: 0.020 s]
  Range (min … max):   12.761 s … 14.552 s    10 runs

Summary
  './simple_raytracer_after' ran
    1.05 ± 0.06 times faster than './simple_raytracer_before'
bjorn3 added a commit that referenced this issue Jan 11, 2020
@bjorn3
Move all cold code to the end of the function
c74b306 
Fixes #836

Benchmark #1: simple-raytracer/raytracer_cg_clif
  Time (mean ± σ):      9.250 s ±  0.056 s    [User: 9.213 s, System: 0.015 s]
  Range (min … max):    9.151 s …  9.348 s    20 runs

Benchmark #2: simple-raytracer/raytracer_cg_clif_cold_separated
  Time (mean ± σ):      9.179 s ±  0.101 s    [User: 9.141 s, System: 0.016 s]
  Range (min … max):    9.070 s …  9.473 s    20 runs

Summary
  'simple-raytracer/raytracer_cg_clif_cold_separated' ran
    1.01 ± 0.01 times faster than 'simple-raytracer/raytracer_cg_clif'
bjorn3 added a commit that referenced this issue Sep 23, 2020
@bjorn3
Also allow returning PassMode::ByValPair directly into an ssa var
934d56a 
Benchmark #1: ./raytracer_cg_clif_pre
  Time (mean ± σ):      8.251 s ±  0.021 s    [User: 8.245 s, System: 0.005 s]
  Range (min … max):    8.225 s …  8.292 s    10 runs

Benchmark #2: ./raytracer_cg_clif_post
  Time (mean ± σ):      8.206 s ±  0.043 s    [User: 8.199 s, System: 0.007 s]
  Range (min … max):    8.168 s …  8.279 s    10 runs
bjorn3 added a commit that referenced this issue Nov 12, 2020
@bjorn3
Avoid muliplications by 1
96c4542 
```
Benchmark #1: ./raytracer_cg_clif_pre
  Time (mean ± σ):      9.553 s ±  0.129 s    [User: 9.543 s, System: 0.008 s]
  Range (min … max):    9.438 s …  9.837 s    10 runs

Benchmark #2: ./raytracer_cg_clif_post
  Time (mean ± σ):      9.463 s ±  0.055 s    [User: 9.452 s, System: 0.008 s]
  Range (min … max):    9.387 s …  9.518 s    10 runs

Summary
  './raytracer_cg_clif_post' ran
    1.01 ± 0.01 times faster than './raytracer_cg_clif_pre'
```
@asaadmohammed74 asaadmohammed74 mentioned this issue Mar 11, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bjorn3 bjorn3

Labels
None yet
Projects
None yet
Milestone
MVP
Development

No branches or pull requests
1 participant
@bjorn3