Skip to content

Implement AES-NI and SHA256 crypto intrinsics using inline asm #1425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 12, 2023

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Nov 11, 2023

Fixes #1409
Fixes #1410
Part of #171
cc RustCrypto/block-ciphers#391

@bjorn3 bjorn3 force-pushed the crypto_intrinsics_inline_asm branch from 440f32b to ca85cc3 Compare November 12, 2023 17:18
@bjorn3 bjorn3 changed the title Implement AES-NI crypto intrinsics using inline asm Implement AES-NI and SHA256 crypto intrinsics using inline asm Nov 12, 2023
@bjorn3
Copy link
Member Author

bjorn3 commented Nov 12, 2023

Added sha256 intrinsic support too. Github has started using AMD processors with support for these instructions which was randomly causing the rustc tests to fail as bootstrap uses them when available.

@bjorn3 bjorn3 marked this pull request as ready for review November 12, 2023 17:32
@bjorn3 bjorn3 merged commit dd25686 into master Nov 12, 2023
@bjorn3 bjorn3 deleted the crypto_intrinsics_inline_asm branch November 12, 2023 17:34
@benwis
Copy link

benwis commented Nov 16, 2023

Ooh! Hoping this gets into nightly soon, nice work!

@bjorn3
Copy link
Member Author

bjorn3 commented Nov 17, 2023

Will be available in tomorrow's nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core-arch Area: Necessary for full core::arch support
Projects
None yet
2 participants