Skip to content

Setup basic r? rustc-dev-guide review group #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2025

Conversation

jieyouxu
Copy link
Member

@jieyouxu jieyouxu commented May 31, 2025

This is a set of opt-in reviewers that PR authors can request reviews from via r? rustc-dev-guide following discussions in #t-compiler/rustc-dev-guide > Adjust triagebot configs @ 💬. I added initial WG members who indicated that they would like to be added to the opt-in review group.

No new PR messages are configured yet, as it is not yet a supported triagebot functionality.

Part of #2428.

jieyouxu added 2 commits May 31, 2025 23:21
So that PR authors can opt-in to request review via
`r? rustc-dev-guide`.
@rustbot rustbot added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label May 31, 2025
@jieyouxu

This comment was marked as off-topic.

@rustbot rustbot assigned jieyouxu and unassigned BoxyUwU May 31, 2025
@jieyouxu

This comment was marked as off-topic.

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i think we can merge this as is and add the welcome message in a follow up

@jieyouxu jieyouxu merged commit e26fce9 into rust-lang:master May 31, 2025
1 check passed
@jieyouxu jieyouxu deleted the review-group branch May 31, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants