Skip to content

Establish basic review group for willing rustc-dev-guide members #2428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 2 tasks
jieyouxu opened this issue May 30, 2025 · 0 comments
Open
1 of 2 tasks

Establish basic review group for willing rustc-dev-guide members #2428

jieyouxu opened this issue May 30, 2025 · 0 comments
Assignees
@jieyouxu
Labels
A-meta Area: meta, about rustc or rustc-dev-guide itself C-enhancement Category: enhancement WG-rustc-dev-guide Working group: rustc-dev-guide

Comments

@jieyouxu
Copy link
Member

jieyouxu commented May 30, 2025 •
edited
Loading

See #t-compiler/rustc-dev-guide > Adjust triagebot configs @ 💬.

  • Setup r? rustc-dev-guide adhoc group (triagebot config). Setup basic r? rustc-dev-guide review group #2431
  • Configure a triagebot PR message to ask for reviewer opt-in

    I would be a bit worried that having automatically assigned reviewers to every PR would discourage people from just writing docs about stuff they know well and then self-merging them to get something in the dev guide

    If we could post a message like "if you want a reviewer please run @rustbot roll-reviewer" or something on PRs that get auto-opened that'd be nice
@jieyouxu jieyouxu self-assigned this May 30, 2025
@jieyouxu jieyouxu added A-meta Area: meta, about rustc or rustc-dev-guide itself WG-rustc-dev-guide Working group: rustc-dev-guide labels May 30, 2025
@rustbot rustbot added the needs-triage This issue needs triage to classify its nature and status label May 30, 2025
@jieyouxu jieyouxu added C-enhancement Category: enhancement and removed needs-triage This issue needs triage to classify its nature and status labels May 30, 2025
@jieyouxu jieyouxu changed the title Establish basic review rotation via assign.adhoc_groups and assign.owners Establish basic review rotation for willing rustc-dev-guide members May 30, 2025
@jieyouxu jieyouxu changed the title Establish basic review rotation for willing rustc-dev-guide members Establish basic review group for willing rustc-dev-guide members May 30, 2025
@jieyouxu jieyouxu mentioned this issue May 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jieyouxu jieyouxu

Labels
A-meta Area: meta, about rustc or rustc-dev-guide itself C-enhancement Category: enhancement WG-rustc-dev-guide Working group: rustc-dev-guide
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jieyouxu @rustbot