Skip to content

Move date-check comment to fix Markdown syntax #1276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Conversation

camelid
Copy link
Member

@camelid camelid commented Dec 15, 2021

The inline code wasn't being rendered correctly.

The inline code wasn't being rendered correctly.
@camelid camelid added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Dec 15, 2021
@jyn514
Copy link
Member

jyn514 commented Dec 15, 2021

I don't understand - why didn't it work before? Why does this change fix it?

@camelid
Copy link
Member Author

camelid commented Dec 15, 2021

Quirks of Markdown–HTML interaction: #1067 (comment)

Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, ok - can you file a bug upstream with pulldown?

@camelid
Copy link
Member Author

camelid commented Dec 15, 2021

Hmm, ok - can you file a bug upstream with pulldown?

Given that GitHub also renders it weirdly before this change, it may not be a bug:

image

@camelid camelid merged commit 7340eb8 into master Dec 15, 2021
@camelid camelid deleted the camelid/fix-syntax branch December 15, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants