Fix formatting of more date references #1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It turns out I missed several in rust-lang#1066.
camelid
added
the
S-waiting-on-review
camelid
commented
Feb 21, 2021
Comment on lines
-74
to
+75
| All told, the inference context stores four kinds of inference variables (as of | ||
| <!-- date: 2018-01 --> January 2018): | ||
| All told, the inference context stores four kinds of inference variables | ||
| (as of <!-- date: 2018-01 --> January 2018): |
There was a problem hiding this comment.
It turns out that mdBook freaks out when a line begins with an HTML comment:
Not sure if it's a bug or expected behavior.
There was a problem hiding this comment.
It generates this HTML:
<p>All told, the inference context stores four kinds of inference variables (as of</p>
<!-- date: 2018-01 --> January 2018):Probably pulldown-cmark is the one doing that.
JohnTitor
approved these changes
Feb 21, 2021
There was a problem hiding this comment.
Seems you still missed the below:
rustc-dev-guide/src/tests/intro.md
Lines 129 to 130 in c4c0f33
Otherwise LGTM (I wonder if we could somehow detect with date-check 🤔).
Great catch, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It turns out I missed several in #1066.