Refactor includes structure, getting rid of rust_internal.h #2118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many changes to code structure are included: - removed TIME_SLICE_IN_MS - removed sychronized_indexed_list - removed region_owned - kernel_owned move to kernel.h, task_owned moved to task.h - global configs moved to rust_globals.h - changed #pragma once to standard guard in rust_upcall.h - got rid of memory.h
|
Beautiful. |
|
Gah. I swear it builds on my computer! I'll take a look |
|
Try this, I suppose. |
|
It was not effective. |
|
Weird. PRIxPTR is clearly defined in inttypes.h which is included by rust_globals.h. Not sure what the problem is yet. I'll just install gcc here and keep trying stuff. |
|
Thanks! |
Kobzol
pushed a commit
to Kobzol/rust
that referenced
this pull request
Dec 30, 2024
Co-authored-by: Jieyou Xu <[email protected]>
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 2, 2025
Co-authored-by: Jieyou Xu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many changes to code structure are included:
Some things are still a bit weird, like the circular depencies between sched_loop and task, but I hope overall it's much more clean than before
Fixes #2083