Skip to content

rt: Get rid of rust_internal.h #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
brson opened this issue Mar 30, 2012 · 1 comment
Closed

rt: Get rid of rust_internal.h #2083

brson opened this issue Mar 30, 2012 · 1 comment
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup.

Comments

@brson
Copy link
Contributor

brson commented Mar 30, 2012

This is an all-powerful header that includes lots of other headers and common definitions and tends to mask dependencies between files. When making big modifications to the runtime, getting the header dependencies straight is a chore, largely, I think, because of this file. Each file should be explicit about the headers it needs instead of counting on the entire world being included via rust_internal.h.
@jamorton jamorton mentioned this issue Apr 3, 2012
Closed
@brson
Copy link
Contributor Author

brson commented Apr 4, 2012

Done by Jonanin.

@brson brson closed this as completed Apr 4, 2012
milibopp added a commit to milibopp/nalgebra that referenced this issue Jan 9, 2015
@milibopp
Use range syntax and new pointer-size types
e7eacdf 
There is an issue in the compiler that makes some workaround necessary here,
see rust-lang/rust#2083
Kobzol pushed a commit to Kobzol/rust that referenced this issue Dec 30, 2024
@fmease
Rename "object safe" to "dyn compatible" (rust-lang#2083)
f6220d0
bors pushed a commit to rust-lang-ci/rust that referenced this issue Jan 2, 2025
@fmease
Rename "object safe" to "dyn compatible" (rust-lang#2083)
b69eb63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-runtime Area: std's runtime and "pre-main" init for handling backtraces, unwinds, stack overflows C-cleanup Category: PRs that clean code up or issues documenting cleanup.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor includes structure, getting rid of rust_internal.h jamorton/rust
1 participant
@brson