Issue #548 : Added command line flag generation method to Builder #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Added new method `command_line_flags` to `Builder` to generate list of command line arguments supplied.[file: src/lib.rs] 2. Added new method `get_set` and `get_items` method to `RegexSet` to return immutable reference to it's fields.[file: src/regex_set.rs] 3. Added simple test case for `command_line_flags` method.[file: src/lib.rs]
fitzgen
approved these changes
Apr 13, 2017
There was a problem hiding this comment.
Thanks for hauling this one over the finish line, @basic-bgnr !
|
@bors-servo r+ |
|
📌 Commit 08c0923 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Apr 13, 2017
Issue #548 : Added command line flag generation method to Builder 1. Added new method `command_line_flags` to `Builder` to generate list of command line arguments supplied.[file: src/lib.rs] 2. Added new method `get_set` and `get_items` method to `RegexSet` to return immutable reference to it's fields.[file: src/regex_set.rs] 3. Added simple test case for `command_line_flags` method.[file: src/lib.rs]
|
☀️ Test successful - status-travis |
|
@fitzgen thank you so much for your guidance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new method
command_line_flagstoBuilderto generatelist of command line arguments supplied.[file: src/lib.rs]
Added new method
get_setandget_itemsmethod toRegexSetto return immutable reference to it's fields.[file: src/regex_set.rs]
Added simple test case for
command_line_flagsmethod.[file: src/lib.rs]