-
Notifications
You must be signed in to change notification settings - Fork 747
Add ability to dump equivalent commandline flags from builder #548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I can mentor an ambitious contributor who might want to take this on. Leave a comment if that is you. |
@fitzgen I volunteer. What's next ? |
@basic-bgnr great! In See We can test it by adding a tests module to the bottom of the file: #[cfg(test)]
mod tests {
#[test]
fn a_unit_test_function() {
// ...
}
} Let me know if you have any questions or if any of that isn't clear. Thanks! :) |
@fitzgen OK great, I'll get to it shortly. |
@fitzgen, I'm still reading the source, will get into actual writing by tonight. Is there any deadline for completion? |
@basic-bgnr no deadline, this is just a useful little feature, not anything anyone is blocked on.
Did you end up getting a build + tests up and running OK? Is there anything we should add/change in CONTRIBUTING.md to make this process more clear? Note that this is only needed if you're running bindgen with a libclang that isn't the system libclang or isn't on the system lib path. |
@fitzgen sorry, the issue was not with building but running. Nothing too much of hassle, but i had to create symbolic link of |
@basic-bgnr how are things going? Any questions I can answer for you? |
@fitzgen nothing right now. Just wondering whether my solution is little bit on the ugly side. How long do you think in terms of LOC should the solution be? |
@basic-bgnr I'm not sure, but I suspect there might be a fair bit of boilerplate. If you want more specific feedback, its easiest to open a work-in-progress PR so we can talk about the code there. |
@fitzgen ok |
@fitzgen, The |
@basic-bgnr a getter that returns immutable references is probably best. |
@basic-bgnr how are things going? Anything I can do to help? |
@fitzgen, I am out of country for days. I'll push the commit within 4-5 days. Thank you. |
Issue #548 : Added command line flag generation method to Builder 1. Added new method `command_line_flags` to `Builder` to generate list of command line arguments supplied.[file: src/lib.rs] 2. Added new method `get_set` and `get_items` method to `RegexSet` to return immutable reference to it's fields.[file: src/regex_set.rs] 3. Added simple test case for `command_line_flags` method.[file: src/lib.rs]
This has been fixed. |
This would be really useful for being able to reproduce (and then minimize with creduce) bindgen failures inside build.rs.
I find myself doing a hacky job of this manually with stylo right now.
The text was updated successfully, but these errors were encountered: