Template instantiation #491
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
fitzgen
force-pushed
the
template-instantiation
branch
from
c404f77 to
ced09f8
Compare
|
r? @emilio Ok, I think this is ready for review. Phew! |
fitzgen
force-pushed
the
template-instantiation
branch
from
ced09f8 to
c0897e1
Compare
emilio
reviewed
Feb 8, 2017
|
|
||
| fn num_template_params(&self, _ctx: &BindgenContext) -> Option<usize> { | ||
| // Wouldn't it be nice if libclang would reliably give us this | ||
| // information‽ |
|
Oh, and thanks for all the cleanups! :) |
|
☔ The latest upstream changes (presumably #480) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@emilio do you think you could try this out on stylo? I don't have a local set up. |
|
Thanks! |
|
Sure! Any chance to get it rebased? That way I'll also test all the other merged changes at the same time :) |
|
Working on a rebase |
This commit adds collect_children, has_children, and has_at_least_num_children methods to Cursor.
The `CanonicalTypeDeclaration` type exists as proof-by-construction that its cursor is the canonical declaration for its type. If you have a `CanonicalTypeDeclaration` instance, you know for sure that the type and cursor match up in a canonical declaration relationship, and it simply cannot be otherwise.
The TemplateDeclaration trait aggregates information about template declarations (separate from instantiations and specializations) and their template parameters into a single source of truth.
This commit create the PartialType type to represent types that we are in the middle of parsing and their cursor where we found them. Additionally, it fixes a long standing FIXME to make `currently_parsed_types` private. Finally, it implements `TemplateDeclaration` for `PartialType` so that we can get information about a partially parsed template declaration type's template parameters.
This commit renames `build_template_wrapper` to `instantiate_template` because that is what it is really doing. Additionally, it completely reworks its logic. Sometimes clang gives us rather sorry ASTs for template instantiations (particularly when they involve incomplete template declarations) and we need to manually reconstruct the template argument nesting.
fitzgen
force-pushed
the
template-instantiation
branch
from
c0897e1 to
41a109a
Compare
|
@emilio rebased! |
|
This is running into some issues within the |
|
Ok latest commit lets me generate SM bindings (which pulls in |
|
@bors-servo r=emilio |
|
📌 Commit 5b5d4f8 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 9, 2017
Template instantiation I very much suspect this needs a rebase, but I haven't done it yet. This is the majority of #446, although it doesn't have the name generation for anonymous named types patches yet (that will be a different PR).
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I very much suspect this needs a rebase, but I haven't done it yet.
This is the majority of #446, although it doesn't have the name generation for anonymous named types patches yet (that will be a different PR).