ir: Don't parse non-semantic-children cursor as inner structs. #486
Conversation
|
|
src/ir/comp.rs
Outdated
| @@ -605,11 +605,17 @@ impl CompInfo { | |||
| CXCursor_UnionDecl | | |||
| CXCursor_ClassTemplate | | |||
| CXCursor_ClassDecl => { | |||
| // We can find non-semantic children here, see: | |||
| // https://github.com/servo/rust-bindgen/issues/482 | |||
There was a problem hiding this comment.
Please leave a one or two sentence description of why/when we can find non-semantic children here, and only link the issue if you think it is still relevant with those sentences.
src/ir/comp.rs
Outdated
| // We can find non-semantic children here, see: | ||
| // https://github.com/servo/rust-bindgen/issues/482 | ||
| if cur.semantic_parent() != cursor { | ||
| return CXChildVisit_Continue; |
There was a problem hiding this comment.
Is it worth lifting this check and early return up out to right before the match?
|
(r=me, but I will let you delegate to bors so you can decide how to respond to my review feedback) |
emilio
force-pushed
the
unresolved-nasty-thingie
branch
from
2a4bfc4 to
7b16c67
Compare
|
@bors-servo r=fitzgen
Thanks for the review Nick! :) |
|
📌 Commit 7b16c67 has been approved by |
|
🔒 Merge conflict |
|
☔ The latest upstream changes (presumably #480) made this pull request unmergeable. Please resolve the merge conflicts. |
emilio
force-pushed
the
unresolved-nasty-thingie
branch
from
7b16c67 to
9f745ab
Compare
|
@bors-servo r=fitzgen |
|
📌 Commit 9f745ab has been approved by |
ir: Don't parse non-semantic-children cursor as inner structs. r? @fitzgen
|
💔 Test failed - status-travis |
emilio
force-pushed
the
unresolved-nasty-thingie
branch
from
9f745ab to
3476447
Compare
|
Fixed a few places where we were passing @bors-servo r=fitzgen |
|
📌 Commit 3476447 has been approved by |
highfive
added
S-awaiting-merge
S-awaiting-review
and removed
S-awaiting-review
S-awaiting-merge
labels
emilio
force-pushed
the
unresolved-nasty-thingie
branch
from
518c1d8 to
3476447
Compare
|
☔ The latest upstream changes (presumably #491) made this pull request unmergeable. Please resolve the merge conflicts. |
emilio
force-pushed
the
unresolved-nasty-thingie
branch
from
3476447 to
331ecab
Compare
|
@bors-servo r=fitzgen |
|
📌 Commit 331ecab has been approved by |
ir: Don't parse non-semantic-children cursor as inner structs. r? @fitzgen
|
☀️ Test successful - status-travis |
r? @fitzgen