clang::Cursor::referenced should return Option<clang::Cursor> #232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -612,7 +612,7 @@ impl Type { | |||
| TypeKind::TemplateAlias(inner.unwrap(), args) | |||
| } | |||
| CXCursor_TemplateRef => { | |||
| let referenced = location.referenced(); | |||
| let referenced = location.referenced().unwrap_or(location); | |||
There was a problem hiding this comment.
This should probably expect the method to return a Cursor, so that we'll know when this doesn't return one (ditto below on the same).
There was a problem hiding this comment.
Yes, we should use either unwrap or expect, if the cursor here is invalid, it's probably a bug. If it isn't, then we can return early an Err here.
There was a problem hiding this comment.
Thank you. I changed unwrap_or to expect.
|
Please claim the relevant issue before working on it, so that we can reduce duplicate efforts :) Also, the merge commits should be removed. |
|
Sorry, I remove merge commits. |
11Takanori
force-pushed
the
124-clang-cursor-referenced-option-cursor
branch
from
058d55c to
76b5372
Compare
|
@bors-servo r+ Thanks! |
|
📌 Commit 76b5372 has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Nov 14, 2016
…rsor, r=emilio clang::Cursor::referenced should return Option<clang::Cursor> Fixes #124 Since I am new to Rust, I hope I didn't do things too badly
luser
pushed a commit
to luser/rust-bindgen
that referenced
this pull request
Mar 27, 2017
…ng#232) We use the kind for the sign and the layout's size for the width, and we wrap unsigned values that are too large to fit inside the determined type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124
Since I am new to Rust, I hope I didn't do things too badly