Skip to content

clang::Cursor::referenced should return Option<clang::Cursor> #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fitzgen opened this issue Oct 24, 2016 · 3 comments
Closed

clang::Cursor::referenced should return Option<clang::Cursor> #124

fitzgen opened this issue Oct 24, 2016 · 3 comments
Labels
C-assigned E-easy I-cleanup

Comments

@fitzgen
Copy link
Member

fitzgen commented Oct 24, 2016

It does not check if the resulting cursor is_valid(), requiring callers to do it, which is a foot gun. Instead, it should check resulting_cursor.is_valid() and return either None or Some. We will also need to fix callers.

I can mentor anyone who wants to pick up this bug.
@highfive
Copy link

Please make a comment here if you intend to work on this issue. Thank you!

@codingHahn
Copy link

@fitzgen How difficult is this bug? I am just getting my foot wet with rust. I am aprox. halfway trough the Rust book (the main one on the website).

@emilio
Copy link
Contributor

emilio commented Nov 7, 2016

@codingHahn This should be doable with that experience :)

@11Takanori 11Takanori mentioned this issue Nov 8, 2016
Merged
bors-servo pushed a commit that referenced this issue Nov 14, 2016
Auto merge of #232 - 11Takanori:124-clang-cursor-referenced-option-cu…
26c3afe 
…rsor, r=emilio

clang::Cursor::referenced should return Option<clang::Cursor>

Fixes #124
Since I am new to Rust, I hope I didn't do things too badly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned E-easy I-cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@fitzgen @emilio @highfive @wafflespeanut @codingHahn