change return value of Type::pointee_type() to Option<Type> #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Please claim the relevant issue before working on it, so that we can reduce duplicate efforts :) |
emilio
approved these changes
Nov 4, 2016
| Type { | ||
| x: clang_getPointeeType(self.x), | ||
| pub fn pointee_type(&self) -> Option<Type> { | ||
| match self.x.kind { |
There was a problem hiding this comment.
can you use self.kind()? not a big deal in this case, but better to be consistent.
There was a problem hiding this comment.
I didn't realise we had that method, thank you!
|
Never mind. I was wrong. |
emilio
reviewed
Nov 4, 2016
| CXType_MemberPointer => { | ||
| unsafe { | ||
| Some(Type { x: clang_getPointeeType(self.x) }) | ||
| } |
There was a problem hiding this comment.
Huh, for some reason my other comment was lost.
Can you assert the type is valid here?
let ret = Type {
x: unsafe { clang_getPointeeType(self.x) },
};
debug_assert!(ret.kind() != CXType_Invalid);
Some(ret)
|
@bors-servo r+ Thanks! |
|
📌 Commit 45dd2ae has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 5, 2016
change return value of Type::pointee_type() to Option<Type> Fixes #137
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #137