Skip to content

clang::Type::pointee_type should return Option<Type> #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fitzgen opened this issue Oct 25, 2016 · 2 comments
Closed

clang::Type::pointee_type should return Option<Type> #137

fitzgen opened this issue Oct 25, 2016 · 2 comments
Labels
C-assigned E-easy I-cleanup

Comments

@fitzgen
Copy link
Member

fitzgen commented Oct 25, 2016

Right now it always does an FFI call to clang_getPointeeType but this is invalid if this type is not a pointer type. We should check that, and if it isn't return None, and if it is make the FFI call and return Some.

I can mentor whoever is interested in working on this.
@highfive
Copy link

Please make a comment here if you intend to work on this issue. Thank you!

@ajnirp ajnirp mentioned this issue Nov 4, 2016
Merged
@wafflespeanut
Copy link
Contributor

@ajnirp is working on this.

bors-servo pushed a commit that referenced this issue Nov 5, 2016
Auto merge of #203 - ajnirp:137-pointee-type, r=emilio
823abd5 
change return value of Type::pointee_type() to Option<Type>

Fixes #137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-assigned E-easy I-cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fitzgen @highfive @wafflespeanut