More testing and test infrastructure stuff #100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include: * Using argparse for argument parsing. This will help when extending the script to skip tests that will only pass when --features llvm_stable is used to build bindgen. * Pulling out all the various steps of the script into helper functions that are easier to digest at a glance, and have docstrings describing their role in the script. * Printing diffs between expected and actual generated bindings rather than the full source text of each.
This adds the ability for tests to supply required features, and if the
bindgen we're testing was not built with those features, then the test
will be skipped. The syntax used to require features is like this:
// bindgen-features: llvm_stable some_experiment another
|
LGTM, though I really want to get rid of the Thanks for doing this :) @bors-servo: r+ |
|
📌 Commit 5ff5d5b has been approved by |
|
☀️ Test successful - status-travis |
Yes, that would be very nice. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See individual commit messages for details.
Fixes #97
r? @emilio