Skip to content

Don't run tests that are expected to fail if --features llvm_stable is not supplied #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fitzgen opened this issue Oct 18, 2016 · 0 comments
Closed

Don't run tests that are expected to fail if --features llvm_stable is not supplied #97

fitzgen opened this issue Oct 18, 2016 · 0 comments

Comments

@fitzgen
Copy link
Member

fitzgen commented Oct 18, 2016

If you build without --features llvm_stable then class_with_typedef will fail. We should add a way to skip such tests if --features llvm_stable is not supplied. And probably vice versa?

Right now, I can either have tests passing locally and failing on CI or failing locally and passing on CI. This is not a good situation to be in.
This was referenced Oct 18, 2016
Closed
Merged
bors-servo pushed a commit that referenced this issue Oct 19, 2016
Auto merge of #100 - fitzgen:more-testing-stuff, r=emilio
58aaf30 
More testing and test infrastructure stuff

See individual commit messages for details.

Fixes #97

r? @emilio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fitzgen