Skip to content

Fix paths for Windows arm64 build #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2024
Merged

Conversation

theKidOfArcrania
Copy link
Contributor

Fixes issue #604 by using Path::join to denote a subpath (as opposed to using forward slash).

@theKidOfArcrania
Copy link
Contributor Author

theKidOfArcrania commented May 13, 2024

Wanted to see if we can get an aarch64 windows build as part of the CI/CD, but it seems like this is something that is not supported properly? Or is there a way and I'm just not familiar with it?

If it does not work, I will still try to test it on a windows arm tablet that I have to make sure that it builds

@Amanieu
Copy link
Member

Amanieu commented May 14, 2024

Github doesn't have any ARM64 Windows runners, so it's fine to just exclude this from CI.

@theKidOfArcrania
Copy link
Contributor Author

Alright, this bug should be fixed, I've tried building windows aarch64 by passing an unc path to --target-dir and it no longer crashes. Though I've taken a comb through the code, and we might have deeper issues if let's say the RUST_COMPILER_RT_ROOT is an unc path, since there are a lot of paths relative to that directory that contain forward slashes. It may also be harder to fix those issues also.

Normally this shouldn't be the case, but in case if this comes up, there may be larger fixes needed.

@Amanieu Amanieu merged commit 7f33201 into rust-lang:master May 15, 2024
23 checks passed
@tgross35
Copy link
Contributor

You could do a cross compile build or at least check on an x64 windows runner to verify the config without running tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants