Skip to content

aarch64 windows build failure #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
theKidOfArcrania opened this issue May 6, 2024 · 1 comment
Closed

aarch64 windows build failure #604

theKidOfArcrania opened this issue May 6, 2024 · 1 comment

Comments

@theKidOfArcrania
Copy link
Contributor

theKidOfArcrania commented May 6, 2024 •
edited
Loading

There is a bug when trying to build for windows arm64 target. See in line 145 concatenates a path of env $OUT_DIR to "/outlined_atomics.rs". The problem arises in windows because $OUT_DIR may resolve to an unc path in windows, and those do not support having forward slashes. Using something like Path.join(...) should fix this bug.
@Amanieu
Copy link
Member

Amanieu commented May 11, 2024

I don't have a setup for building arm64 windows. Could you submit a PR with the fix once you have tested it?

This was referenced May 13, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Amanieu @theKidOfArcrania