Skip to content

Add a fix for aarch64-darwin and enable it in CI #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Add a fix for aarch64-darwin and enable it in CI #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
800d97b
Change aarch64_linux module and lse tests to have the same gating
tgross35 Apr 13, 2024
1e1376e
Add CI testing for AArch64 Darwin
tgross35 Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ jobs:
fail-fast: false
matrix:
include:
- target: aarch64-apple-darwin
os: macos-14
rust: nightly
- target: aarch64-unknown-linux-gnu
os: ubuntu-latest
rust: nightly
Expand Down Expand Up @@ -81,6 +84,8 @@ jobs:
os: windows-latest
rust: nightly-x86_64-gnu
steps:
- name: Print runner information
run: uname -a
- uses: actions/checkout@v4
with:
submodules: true
Expand Down
5 changes: 1 addition & 4 deletions testcrate/tests/lse.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,5 @@
#![feature(decl_macro)] // so we can use pub(super)
#![cfg(all(
any(target_arch = "aarch64", target_arch = "arm64ec"),
not(feature = "no-asm")
))]
#![cfg(all(target_arch = "aarch64", target_os = "linux", not(feature = "no-asm")))]

/// Translate a byte size to a Rust type.
macro int_ty {
Expand Down