Add a fix for aarch64-darwin and enable it in CI #592
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgross35
force-pushed
the
lse-gating
branch
2 times, most recently
from
f00788c to
adb0dce
Compare
tgross35
changed the title
|
@Amanieu this PR is pretty small, would you be able to merge it? It would just make it easier for me to develop/test locally without carrying an extra patch around. |
Amanieu
reviewed
Apr 16, 2024
src/lib.rs
Outdated
| @@ -62,7 +62,11 @@ pub mod arm; | |||
| #[cfg(any(target_arch = "aarch64", target_arch = "arm64ec"))] | |||
| pub mod aarch64; | |||
|
|
|||
| #[cfg(all(target_arch = "aarch64", target_os = "linux", not(feature = "no-asm"),))] | |||
| #[cfg(all( | |||
| any(target_arch = "aarch64", target_arch = "arm64ec"), | |||
There was a problem hiding this comment.
ARM64EC only exists on Windows.
There was a problem hiding this comment.
Actually, would it be better to leave arm64ec but change the cfg to not(target_os = "macos") so it still gets tested on Windows? I don't know where this is needed but it must have been passing okay on the windows platforms.
Amanieu
reviewed
Apr 16, 2024
Trying to run testcrate on non-linux aarch64 currently hits a compilation error. Make this test linux-only, to be consistent with the `aarch64_linux` module that it depends on. Additionally, enable the `aarch64_linux` module for `target_arch = "arm64ec"` to be the same as these tests.
The Apple ARM silicon has been around for a while now and hopefully will become Rust Tier 1 at some point. Add it to CI since it is distinct enough from aarch64-linux and x86_86-darwin that there may be differences.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes two commits:
Change aarch64_linux module and lse tests to have the same gating
Trying to run testcrate on non-linux aarch64 currently hits a compilation error. Make this test linux-only, to be consistent with the
aarch64_linuxmodule that it depends on.Additionally, enable the
aarch64_linuxmodule fortarget_arch = "arm64ec"to be the same as these tests.Add CI testing for AArch64 Darwin
The Apple ARM silicon has been around for a while now and hopefully will become Rust Tier 1 at some point. Add it to CI since it is distinct enough from aarch64-linux and x86_86-darwin that there may be differences.