Build: remove pdflatex support
#9967
Conversation
`pdflatex` is only called for project using `Sphinx<=1.6.1` --which we haven't had anyone in the last 6 months. Closes #9886
There was a problem hiding this comment.
LGTM 👍 (seems maybe some tests need to be sync'ed with the new/fewer commands being called)
Just want your opinion about whether this is definitely breaking super-old environments with Sphinx<1.6 and if that can be avoided by simply not calling latexmk in those environments ⬇️
| @@ -3,8 +3,6 @@ Sphinx PDFs with Unicode | |||
|
|
|||
| Sphinx offers different `LaTeX engines`_ that have better support for Unicode characters | |||
| and non-European languages like Japanese or Chinese. | |||
| By default Sphinx uses ``pdflatex``, | |||
| which does not have good support for Unicode characters and may make the PDF builder fail. | |||
There was a problem hiding this comment.
Can we keep "By default, Sphinx uses latexmk <https://mg.readthedocs.io/latexmk.html>_" or something similar?
I'm not sure how it affects Unicode characters, so seems good to delete.
There was a problem hiding this comment.
Yeah, latexmk is the good one to deal with Unicode characters. That's why I deleted the sentence completely.
There was a problem hiding this comment.
Yeah, I was thinking that it's nice to inform people about the default builder in case they need to troubleshoot something.
|
@agjohnson @ericholscher I'd like your opinions on this because I may not be considering something that you will 😄 |
There was a problem hiding this comment.
This seems like a positive change and simplification. I don't have a full memory of why this was added, but I think it should be safe to delete at this point.
We should likely have somewhere in our docs that we mention supported versions of Sphinx, and begrudgingly list 1.8.7 or whatever is the one we install still by default on old projects, until we can migrate them. 🙃
…mitos/remove-pdflatex-support
pdflatexis only called for project usingSphinx<=1.6.1--which we haven't had anyone in the last 6 months.Closes #9886