Skip to content

Build: remove support for pdflatex #9907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humitos opened this issue Jan 17, 2023 · 2 comments
Closed

Build: remove support for pdflatex #9907

humitos opened this issue Jan 17, 2023 · 2 comments
Labels
Accepted Accepted issue on our roadmap

Comments

@humitos
Copy link
Member

humitos commented Jan 17, 2023

Our current code decides whether using pdflatex or latexmk depending on the Sphinx version. It uses pdflatex when sphinx<=1.6.x and for all the other versions it uses latexmk:

command = [
self.python_env.venv_bin(filename='python'),
'-c',
(
'"'
'import sys; '
'import sphinx; '
'sys.exit(0 if sphinx.version_info >= (1, 6, 1) else 1)'
'"'
),
]

I think we could safely remove this chunk of code since nobody is using such an old version to build their documentation with Sphinx. This Metabase query shows that the oldest version currently used on Read the Docs is 1.8.6 1

Footnotes

  1. this is because we are forcing pinning to that version for old projects

@humitos humitos added the Accepted Accepted issue on our roadmap label Jan 17, 2023
@SyedMa3
Copy link
Contributor

SyedMa3 commented Jun 18, 2023

I can't find this chunk of code in the main branch. So assuming this code is removed, so issue can be closed? @humitos

@humitos
Copy link
Member Author

humitos commented Jun 19, 2023

Yes, we can close this issue. This was done in #9967. Thanks 👍🏼

@humitos humitos closed this as completed Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap
Projects
None yet
Development

No branches or pull requests

2 participants