Skip to content

Docs: Relabel Localization as Explanation (Diátaxis) #9790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

benjaoming
Copy link
Contributor

@benjaoming benjaoming commented Dec 8, 2022

Refs: #9746


📚 Documentation previews 📚

@benjaoming benjaoming added the Improvement Minor improvement to code label Dec 8, 2022
@benjaoming benjaoming self-assigned this Dec 8, 2022
@benjaoming benjaoming changed the base branch from main to diataxis/main December 8, 2022 16:32
@benjaoming benjaoming marked this pull request as ready for review December 13, 2022 18:26
@benjaoming benjaoming requested a review from a team as a code owner December 13, 2022 18:26
@benjaoming
Copy link
Contributor Author

benjaoming commented Dec 13, 2022

@ericholscher it's possible to have a lot of improvements here. But I feel like translation is a large subject that we might want to push to later iterations?

One of the improvements would be a diagram for the translation workflow. We already have "add a diagram" opened as a suggestion in #9675 and I think we should be careful about how many times we want diagrams added before we should decide on an approach to easily have Mermaid diagrams added (it eventually wasn't that easy in my first attempt because of small technical reasons).

@ericholscher
Copy link
Member

Yea, I think a small update here is best. We don't get a ton of users using this feature, so I'm less worried about it's overall quality.

Copy link
Member

@ericholscher ericholscher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍

benjaoming and others added 2 commits December 13, 2022 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Minor improvement to code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants