Skip to content

Dependencies: all packages updated via pip-tools #9688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Dependencies: all packages updated via pip-tools #9688

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81f5946
Dependencies: all packages updated via pip-tools
humitos Oct 23, 2022
7170e4e
Dependencies: pin `dj-stripe` and run upgrade again
humitos Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion requirements/debug.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ stack-data==0.5.1
# via ipython
toml==0.10.2
# via ipdb
traitlets==5.4.0
traitlets==5.5.0
# via
# ipython
# matplotlib-inline
Expand Down
20 changes: 8 additions & 12 deletions requirements/deploy.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,11 +28,11 @@ billiard==3.6.4.0
# via
# -r requirements/pip.txt
# celery
boto3==1.24.91
boto3==1.24.96
# via
# -r requirements/pip.txt
# django-storages
botocore==1.27.91
botocore==1.27.96
# via
# -r requirements/pip.txt
# boto3
Expand Down Expand Up @@ -96,7 +96,7 @@ distlib==0.3.6
# virtualenv
dj-pagination==2.5.0
# via -r requirements/pip.txt
dj-stripe==2.6.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is some breaking changes added in 2.7.0; so we should take a look at the release notes first: https://github.com/dj-stripe/dj-stripe/releases cc @stsewd

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The breaking change is around webhooks and how to manage API keys, they are now in the database. I did a small test, and don't think this will cause any downtime. The steps would be:

  • Run the migrations on web extra
  • Create an API key on the admin
    (/admin/djstripe/apikey/)
  • Release the webs
  • Create a webhook endpoint after the release is done
    (/admin/djstripe/webhookendpoint/), the webhook will be created on stripe automatically.
  • Deactivate the old webhook

The old and the new webhook will work at the same time, so we won't lose any events.

The migration is https://github.com/dj-stripe/dj-stripe//blob/bc0bd5c1/djstripe/migrations/0011_2_7.py, there are a couple of new fields that aren't nullable, but if the webhooks fail, stripe will retry them, and by that time the new code would be live.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. I will revert this upgrade and I'll create an issue track this particular one since it's not trivial

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9706

dj-stripe==2.7.2
# via -r requirements/pip.txt
django==3.2.16
# via
Expand Down Expand Up @@ -244,7 +244,7 @@ matplotlib-inline==0.1.6
# via ipython
newrelic==7.4.0.172
# via -r requirements/deploy.in
oauthlib==3.2.1
oauthlib==3.2.2
# via
# -r requirements/pip.txt
# requests-oauthlib
Expand Down Expand Up @@ -288,7 +288,7 @@ pygments==2.13.0
# -r requirements/pip.txt
# ipython
# sphinx
pyjwt[crypto]==2.5.0
pyjwt[crypto]==2.6.0
# via
# -r requirements/pip.txt
# django-allauth
Expand All @@ -307,7 +307,7 @@ python3-openid==3.2.0
# via
# -r requirements/pip.txt
# django-allauth
pytz==2022.4
pytz==2022.5
# via
# -r requirements/pip.txt
# babel
Expand Down Expand Up @@ -344,7 +344,7 @@ s3transfer==0.6.0
# boto3
selectolax==0.3.11
# via -r requirements/pip.txt
sentry-sdk==1.9.10
sentry-sdk==1.10.1
# via structlog-sentry
six==1.16.0
# via
Expand Down Expand Up @@ -413,14 +413,10 @@ toml==0.10.2
# via
# -r requirements/pip.txt
# dparse
traitlets==5.4.0
traitlets==5.5.0
# via
# ipython
# matplotlib-inline
types-cryptography==3.3.23.1
# via
# -r requirements/pip.txt
# pyjwt
ua-parser==0.16.1
# via
# -r requirements/pip.txt
Expand Down
18 changes: 7 additions & 11 deletions requirements/docker.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,11 @@ billiard==3.6.4.0
# via
# -r requirements/pip.txt
# celery
boto3==1.24.91
boto3==1.24.96
# via
# -r requirements/pip.txt
# django-storages
botocore==1.27.91
botocore==1.27.96
# via
# -r requirements/pip.txt
# boto3
Expand Down Expand Up @@ -106,7 +106,7 @@ distlib==0.3.6
# virtualenv
dj-pagination==2.5.0
# via -r requirements/pip.txt
dj-stripe==2.6.3
dj-stripe==2.7.2
# via -r requirements/pip.txt
django==3.2.16
# via
Expand Down Expand Up @@ -265,7 +265,7 @@ matplotlib-inline==0.1.6
# via
# -r requirements/debug.txt
# ipython
oauthlib==3.2.1
oauthlib==3.2.2
# via
# -r requirements/pip.txt
# requests-oauthlib
Expand Down Expand Up @@ -330,7 +330,7 @@ pygments==2.13.0
# pdbpp
# rich
# sphinx
pyjwt[crypto]==2.5.0
pyjwt[crypto]==2.6.0
# via
# -r requirements/pip.txt
# django-allauth
Expand All @@ -353,7 +353,7 @@ python3-openid==3.2.0
# via
# -r requirements/pip.txt
# django-allauth
pytz==2022.4
pytz==2022.5
# via
# -r requirements/pip.txt
# babel
Expand Down Expand Up @@ -467,15 +467,11 @@ tomli==2.0.1
# via tox
tox==3.26.0
# via -r requirements/docker.in
traitlets==5.4.0
traitlets==5.5.0
# via
# -r requirements/debug.txt
# ipython
# matplotlib-inline
types-cryptography==3.3.23.1
# via
# -r requirements/pip.txt
# pyjwt
ua-parser==0.16.1
# via
# -r requirements/pip.txt
Expand Down
18 changes: 7 additions & 11 deletions requirements/docs.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ billiard==3.6.4.0
# via
# -r requirements/pip.txt
# celery
boto3==1.24.91
boto3==1.24.96
# via
# -r requirements/pip.txt
# django-storages
botocore==1.27.91
botocore==1.27.96
# via
# -r requirements/pip.txt
# boto3
Expand Down Expand Up @@ -93,7 +93,7 @@ distlib==0.3.6
# virtualenv
dj-pagination==2.5.0
# via -r requirements/pip.txt
dj-stripe==2.6.3
dj-stripe==2.7.2
# via -r requirements/pip.txt
django==3.2.16
# via
Expand Down Expand Up @@ -243,7 +243,7 @@ mdurl==0.1.2
# via markdown-it-py
myst-parser==0.17.2
# via -r requirements/docs.in
oauthlib==3.2.1
oauthlib==3.2.2
# via
# -r requirements/pip.txt
# requests-oauthlib
Expand All @@ -255,7 +255,7 @@ packaging==21.3
# docker
# dparse
# sphinx
pbr==5.10.0
pbr==5.11.0
# via sphinxcontrib-video
platformdirs==2.5.2
# via
Expand All @@ -275,7 +275,7 @@ pygments==2.13.0
# sphinx
# sphinx-prompt
# sphinx-tabs
pyjwt[crypto]==2.5.0
pyjwt[crypto]==2.6.0
# via
# -r requirements/pip.txt
# django-allauth
Expand All @@ -294,7 +294,7 @@ python3-openid==3.2.0
# via
# -r requirements/pip.txt
# django-allauth
pytz==2022.4
pytz==2022.5
# via
# -r requirements/pip.txt
# babel
Expand Down Expand Up @@ -434,10 +434,6 @@ toml==0.10.2
# dparse
tornado==6.2
# via livereload
types-cryptography==3.3.23.1
# via
# -r requirements/pip.txt
# pyjwt
typing-extensions==4.4.0
# via myst-parser
ua-parser==0.16.1
Expand Down
16 changes: 6 additions & 10 deletions requirements/lint.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,11 @@ billiard==3.6.4.0
# via
# -r requirements/pip.txt
# celery
boto3==1.24.91
boto3==1.24.96
# via
# -r requirements/pip.txt
# django-storages
botocore==1.27.91
botocore==1.27.96
# via
# -r requirements/pip.txt
# boto3
Expand Down Expand Up @@ -96,7 +96,7 @@ distlib==0.3.6
# virtualenv
dj-pagination==2.5.0
# via -r requirements/pip.txt
dj-stripe==2.6.3
dj-stripe==2.7.2
# via -r requirements/pip.txt
django==3.2.16
# via
Expand Down Expand Up @@ -247,7 +247,7 @@ mccabe==0.6.1
# flake8
# prospector
# pylint
oauthlib==3.2.1
oauthlib==3.2.2
# via
# -r requirements/pip.txt
# requests-oauthlib
Expand Down Expand Up @@ -292,7 +292,7 @@ pygments==2.13.0
# via
# -r requirements/pip.txt
# sphinx
pyjwt[crypto]==2.5.0
pyjwt[crypto]==2.6.0
# via
# -r requirements/pip.txt
# django-allauth
Expand Down Expand Up @@ -330,7 +330,7 @@ python3-openid==3.2.0
# via
# -r requirements/pip.txt
# django-allauth
pytz==2022.4
pytz==2022.5
# via
# -r requirements/pip.txt
# babel
Expand Down Expand Up @@ -437,10 +437,6 @@ toml==0.10.2
# dparse
# pylint
# requirements-detector
types-cryptography==3.3.23.1
# via
# -r requirements/pip.txt
# pyjwt
ua-parser==0.16.1
# via
# -r requirements/pip.txt
Expand Down
14 changes: 6 additions & 8 deletions requirements/pip.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ babel==2.10.3
# via sphinx
billiard==3.6.4.0
# via celery
boto3==1.24.91
boto3==1.24.96
# via django-storages
botocore==1.27.91
botocore==1.27.96
# via
# boto3
# s3transfer
Expand Down Expand Up @@ -54,7 +54,7 @@ distlib==0.3.6
# via virtualenv
dj-pagination==2.5.0
# via -r requirements/pip.in
dj-stripe==2.6.3
dj-stripe==2.7.2
# via -r requirements/pip.in
django==3.2.16
# via
Expand Down Expand Up @@ -169,7 +169,7 @@ markdown==3.4.1
# via -r requirements/pip.in
markupsafe==2.1.1
# via jinja2
oauthlib==3.2.1
oauthlib==3.2.2
# via requests-oauthlib
orjson==3.8.0
# via -r requirements/pip.in
Expand All @@ -189,7 +189,7 @@ pygments==2.13.0
# via
# -r requirements/pip.in
# sphinx
pyjwt[crypto]==2.5.0
pyjwt[crypto]==2.6.0
# via django-allauth
pyparsing==3.0.9
# via packaging
Expand All @@ -202,7 +202,7 @@ python-dateutil==2.8.2
# elasticsearch-dsl
python3-openid==3.2.0
# via django-allauth
pytz==2022.4
pytz==2022.5
# via
# -r requirements/pip.in
# babel
Expand Down Expand Up @@ -277,8 +277,6 @@ structlog==22.1.0
# django-structlog
toml==0.10.2
# via dparse
types-cryptography==3.3.23.1
# via pyjwt
ua-parser==0.16.1
# via user-agents
unicode-slugify @ git+https://github.com/mozilla/unicode-slugify@b696c37
Expand Down
16 changes: 6 additions & 10 deletions requirements/testing.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,11 @@ billiard==3.6.4.0
# via
# -r requirements/pip.txt
# celery
boto3==1.24.91
boto3==1.24.96
# via
# -r requirements/pip.txt
# django-storages
botocore==1.27.91
botocore==1.27.96
# via
# -r requirements/pip.txt
# boto3
Expand Down Expand Up @@ -93,7 +93,7 @@ distlib==0.3.6
# virtualenv
dj-pagination==2.5.0
# via -r requirements/pip.txt
dj-stripe==2.6.3
dj-stripe==2.7.2
# via -r requirements/pip.txt
django==3.2.16
# via
Expand Down Expand Up @@ -233,7 +233,7 @@ markupsafe==2.1.1
# jinja2
mercurial==6.2.3
# via -r requirements/testing.in
oauthlib==3.2.1
oauthlib==3.2.2
# via
# -r requirements/pip.txt
# requests-oauthlib
Expand Down Expand Up @@ -266,7 +266,7 @@ pygments==2.13.0
# via
# -r requirements/pip.txt
# sphinx
pyjwt[crypto]==2.5.0
pyjwt[crypto]==2.6.0
# via
# -r requirements/pip.txt
# django-allauth
Expand Down Expand Up @@ -300,7 +300,7 @@ python3-openid==3.2.0
# via
# -r requirements/pip.txt
# django-allauth
pytz==2022.4
pytz==2022.5
# via
# -r requirements/pip.txt
# babel
Expand Down Expand Up @@ -406,10 +406,6 @@ toml==0.10.2
# dparse
tomli==2.0.1
# via pytest
types-cryptography==3.3.23.1
# via
# -r requirements/pip.txt
# pyjwt
ua-parser==0.16.1
# via
# -r requirements/pip.txt
Expand Down