Dependencies: all packages updated via pip-tools #9688
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
stsewd
and removed request for
stsewd
requirements/deploy.txt
Outdated
| @@ -96,7 +96,7 @@ distlib==0.3.6 | |||
| # virtualenv | |||
| dj-pagination==2.5.0 | |||
| # via -r requirements/pip.txt | |||
| dj-stripe==2.6.3 | |||
There was a problem hiding this comment.
There is some breaking changes added in 2.7.0; so we should take a look at the release notes first: https://github.com/dj-stripe/dj-stripe/releases cc @stsewd
There was a problem hiding this comment.
The breaking change is around webhooks and how to manage API keys, they are now in the database. I did a small test, and don't think this will cause any downtime. The steps would be:
- Run the migrations on web extra
- Create an API key on the admin
(/admin/djstripe/apikey/) - Release the webs
- Create a webhook endpoint after the release is done
(/admin/djstripe/webhookendpoint/), the webhook will be created on stripe automatically. - Deactivate the old webhook
The old and the new webhook will work at the same time, so we won't lose any events.
The migration is https://github.com/dj-stripe/dj-stripe//blob/bc0bd5c1/djstripe/migrations/0011_2_7.py, there are a couple of new fields that aren't nullable, but if the webhooks fail, stripe will retry them, and by that time the new code would be live.
There was a problem hiding this comment.
OK. I will revert this upgrade and I'll create an issue track this particular one since it's not trivial
humitos
force-pushed
the
dependencies/pip-tools-9926b0f
branch
from
2d533a8 to
7170e4e
Compare
Dependencies: all packages updated via pip-tools