-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Embedded js: remove more dependency on jquery #9515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
191b070
Embedded js: remove some dependency from jquery
stsewd 886b4db
Updates from review
stsewd e27297b
Merge branch 'main' into remove-some-jquery
stsewd 366a2fa
Update common
stsewd 25e64d0
Object.keys is an Array!
stsewd 55e61da
Embedded js: remove more dependency on jquery
stsewd 587d6c2
Merge branch 'main' into remove-more-jquery
stsewd File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
/** | ||
* Create and return DOM nodes with given attributes. | ||
* | ||
* @param {String} nodeName name of the node | ||
* @param {Object} attributes obj of attributes to be assigned to the node | ||
* @return {Object} DOM node | ||
stsewd marked this conversation as resolved.
Show resolved
Hide resolved
|
||
*/ | ||
const createDomNode = (nodeName, attributes) => { | ||
let node = document.createElement(nodeName); | ||
if (attributes) { | ||
for (let attr of Object.keys(attributes)) { | ||
node.setAttribute(attr, attributes[attr]); | ||
} | ||
} | ||
return node; | ||
}; | ||
|
||
module.exports = { createDomNode }; |
37 changes: 17 additions & 20 deletions
37
readthedocs/core/static-src/core/js/doc-embed/version-compare.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to specify that we're using this function from
utils
, or is the compiler smart enough to know what is happening if we add additional utils functions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The compile step will resolve the functions in
utils.js
for use here, yeah. This syntax will only importcreateDomNode
fromutils.js
. If more functions are added toutils.js
, they won't automatically be imported here, but could be withconst { createDomNode, someOtherUtil } = ..