Embedded js: remove more dependency on jquery #9515
Conversation
There was a problem hiding this comment.
This looks like a great update to me. I'm 👍 on it, assuming we test that it continues to work. @agjohnson might also have some style feedback, but the small refactors look pretty straightforward.
|
|
||
| const rtddata = require('./rtd-data'); | ||
| const xss = require('xss/lib/index'); | ||
| const { createDomNode } = require("./utils"); |
There was a problem hiding this comment.
Do we need to specify that we're using this function from utils, or is the compiler smart enough to know what is happening if we add additional utils functions?
There was a problem hiding this comment.
The compile step will resolve the functions in utils.js for use here, yeah. This syntax will only import createDomNode from utils.js. If more functions are added to utils.js, they won't automatically be imported here, but could be with const { createDomNode, someOtherUtil } = ..
This is on top of #9508
📚 Documentation previews 📚
docs): https://docs--9515.org.readthedocs.build/en/9515/dev): https://dev--9515.org.readthedocs.build/en/9515/