Skip to content

Add mc client to web container #9331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 15, 2022
Merged

Add mc client to web container #9331

merged 1 commit into from
Jun 15, 2022

Conversation

benjaoming
Copy link
Contributor

Dependency of readthedocs/common#144

@benjaoming benjaoming requested a review from a team as a code owner June 14, 2022 13:38
@benjaoming benjaoming requested a review from humitos June 14, 2022 13:38
humitos
humitos approved these changes Jun 14, 2022
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@benjaoming
Copy link
Contributor Author

Test failure is fixed in #9302

@benjaoming benjaoming merged commit 806fc05 into readthedocs:main Jun 15, 2022
@benjaoming benjaoming deleted the add-mc-to-common-server-container branch June 15, 2022 08:19
@benjaoming benjaoming mentioned this pull request Jun 15, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees

@benjaoming benjaoming

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benjaoming @humitos