Updates and fixes to Development Install guide #9319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaoming
force-pushed
the
docs/install-updates
branch
from
eac0f0e to
6717231
Compare
benjaoming
changed the title
humitos
reviewed
Jun 9, 2022
There was a problem hiding this comment.
Changes look good!
We have solved some of the issues that are mentioned here, like the env variable or the MinIO permissions in the past. So, I'd prefer to bugfix them to avoid manual intervention there instead of "document the bugfix" that requires extra actions. The fewer commands we have to run to set up the environment, the better.
stsewd
reviewed
Jun 9, 2022
humitos
reviewed
Jun 9, 2022
This was referenced Jun 10, 2022
benjaoming
force-pushed
the
docs/install-updates
branch
from
22921fb to
ef75733
Compare
humitos
requested changes
Jun 13, 2022
humitos
added a commit
to readthedocs/common
that referenced
this pull request
Jun 13, 2022
This was referenced Jun 13, 2022
…tup. We need to make expected system requirements explict perhaps.
Co-authored-by: Manuel Kaufmann <[email protected]>
Co-authored-by: Manuel Kaufmann <[email protected]>
Co-authored-by: Santos Gallegos <[email protected]> Co-authored-by: Manuel Kaufmann <[email protected]>
…e why privacy/incognito sessions may be needed
benjaoming
force-pushed
the
docs/install-updates
branch
from
2ccb6b8 to
5eaa6dd
Compare
stsewd
reviewed
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work-around for COMPOSE_PROJECT_NAME should not be required for development setup #9318Fixed incommonmasterbranch instead ofmain