Updating initial fixture #8948
Closed
Updating initial fixture #8948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
@tanvimoharir this looks good and since tests passed, I think that we shouldn't have any issues with test cases -- I'm going to try to include your work in #9319 |
Thanks @benjaoming :) Do let me know if there is anything which I can do (any additional changes required etc) |
benjaoming
added a commit
to benjaoming/readthedocs.org
that referenced
this pull request
Jun 10, 2022
|
Thanks so much for the contribution @tanvimoharir! We cherry-picked your commits in this PR: #9319 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating fixture as per #8914