Proxito: do not serve non-existent versions #9048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
approved these changes
Mar 29, 2022
readthedocs/proxito/views/serve.py
Outdated
| # Skip serving versions that don't exist or are not active. This is to | ||
| # avoid serving files that we have in the storage, but its associated | ||
| # version does not exist anymore or it was de-activated | ||
| if not version or not version.active: |
There was a problem hiding this comment.
I'm curious how this will impact our 404's. It's definitely the right approach, but something to watch on deployment.
Avoid serving files that are still in the storage (S3) for some reason but its associated version was deleted or de-activated. Closes readthedocs/readthedocs-ops#1139
humitos
force-pushed
the
humitos/dont-serve-inactive-non-existent-versions
branch
from
305b6d3 to
7d238cf
Compare
|
@ericholscher please take another look at this. There were some tests failing and when I review them it seemed that I had a mistake in the logic that returns 404s. I've updated that logic to handle all the cases:
This logic does not interfere with the case:
I'm not sure if I was able to explain this here or even in the comment. Feel free to make a suggestion if you find a better way to explain this 😄 |
ericholscher
approved these changes
Mar 31, 2022
Co-authored-by: Eric Holscher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid serving files that are still in the storage (S3) for some reason but its
associated version was deleted or de-activated.
Closes https://github.com/readthedocs/readthedocs-ops/issues/1139